search

tractorcow-farm / silverstripe-fluent

Multi-language translate module for Silverstripe, without having to manage separate site trees.
BSD 3-Clause "New" or "Revised" License
91 stars 109 forks source link

FIX Preview link when no locale set #861

Closed emteknetnz closed 2 months ago

emteknetnz commented 2 months ago

Issue https://github.com/silverstripe/.github/issues/272

Fixes vendor/silverstripe/cms/tests/behat/features/preview-a-page.feature:12 - which breaks when silverstripe/recipe-kitchen-sink is run including silverstripe/cms behat tests.

The issue that behat is running into is that the preview link will not show anything as no locale has been defined in a behat context

emteknetnz commented 2 months ago

Updated

emteknetnz commented 2 months ago

Surprisingly yes, looks like the previous CI failure was actually just from rendering the preview link from a template.

Reverted as second commit, so do not squash merge