search

tractorcow / silverstripe-dynamiccache

Simple on the fly caching of dynamic content for Silverstripe
39 stars 27 forks source link

Added support for Dataobjects and updated SS version #10

Closed ARNHOE closed 10 years ago

tractorcow commented 10 years ago

Hi @ARNHOE , is there any reason this won't work on SS 3.0?

After I pull this I can add some documentation. I might also refactor the DynamicCachePageExtension class so that it extends this.

tractorcow commented 10 years ago

I do realise the branch number is a bit odd, but it does work fine for 3.0.

ARNHOE commented 10 years ago

I didnt change it because of not working on a particular version. But simply because a couple lines below it says

composer require "tractorcow/silverstripe-dynamiccache": "3.1.*@dev"
tractorcow commented 10 years ago

Hi @ARNHOE ,

3.1.* is the version of dynamic cache, not the version of silverstripe required. I had originally designed this to work with 3.1, but I found that it worked perfectly fine with 3.0 so I left the requirement looser.

If it's ok with you I'll manually merge in your extension (I don't know how to edit pull requests).

tractorcow commented 10 years ago

I've updated the documentation and done some additional refactoring based on your new class. https://github.com/tractorcow/silverstripe-dynamiccache/commit/e0d03b979cfb03dd2f79cbabb192fc034a6e7312

Thanks @ARNHOE , it's always a pleasure to work with you. :)

ARNHOE commented 10 years ago

Hey @tractorcow ,

Ha! I don't mind if you edit my "code" wasn't particular rocket science!

And thanks for your awesome modules!