tractorcow / silverstripe-dynamiccache

Simple on the fly caching of dynamic content for Silverstripe
39 stars 27 forks source link

Minify HTML #28

Closed pitchandtone closed 6 years ago

pitchandtone commented 8 years ago

Is there a reason this doesn't happen out of the box? Seems like a good place to do it.

tractorcow commented 8 years ago

That's actually a kind of cool idea, although is the cache the best place to put it? I feel maybe this should be an extension on SSViewer.

jonom commented 8 years ago

I'm not sure minifying HTML is worthwhile. Probably redundant if you're using gzip and not likely to give you significant gains compared to minifying and combining JS + CSS. I also agree with @tractorcow that if you do want to minify HTML, this module probably isn't the right place to do it.

dhensby commented 6 years ago

agreed - should be closed