search

tractorcow / silverstripe-dynamiccache

Simple on the fly caching of dynamic content for Silverstripe
39 stars 27 forks source link

Make the class a real abstract #47

Closed Firesphere closed 7 years ago

Firesphere commented 7 years ago

Abstracts should have methods that do something, or actual abstracts. Neither of those were actually true.

silbinarywolf commented 7 years ago

If you're going to change it to be like that, then it might as well just be an interface that you use when extending 'DataExtension', right?

tractorcow commented 7 years ago

I think abstract methods means you must implement them. The reason these are blank are as placeholders for optional methods which may be safely left blank. They really just exist as typehints to support extension implementations.

The reason the class in abstract but none of the members are is that the class itself is useless, unless you implement at least one of the optional methods.

Firesphere commented 7 years ago

Fair enough :)