search

tractorcow / silverstripe-dynamiccache

Simple on the fly caching of dynamic content for Silverstripe
39 stars 27 forks source link

fix(IgnoredPages): Comment out / Remove 'UserDefinedForm' from ignoredPages. #54

Closed silbinarywolf closed 7 years ago

silbinarywolf commented 7 years ago

fix(IgnoredPages): Comment out / Remove 'UserDefinedForm' from ignoredPages.

We don't want the UDF form to be cached and working around the YML for ignoredPages is annoying. Do you remember why this was added in?

tractorcow commented 7 years ago

It was added in so that validation errors don't get cached, otherwise you can see someone else's errors, which is a privacy concern. :)

silbinarywolf commented 7 years ago

Isn't that prevented with this? https://github.com/tractorcow/silverstripe-dynamiccache/blob/master/code/DynamicCache.php#L132

tractorcow commented 7 years ago

Oh, I guess so.

Please change your PR to remove instead of comment out the option, and I'll merge.

tractorcow commented 7 years ago

Actually make it an empty array.

  ignoredPages: []
silbinarywolf commented 7 years ago

Done!