search

tractorcow / silverstripe-dynamiccache

Simple on the fly caching of dynamic content for Silverstripe
39 stars 27 forks source link

Caching on a machine level - most likely not related to this module. #71

Open sunnysideup opened 6 years ago

sunnysideup commented 6 years ago

We are experiencing some weird caching issues that, very likely, do NOT to relate to this module. I am still posting here just in case anyone else has experienced the same or in case the module does affect it in some weird way.

Here is how to recreate bug:

  1. We create an "ADMIN only" page - visit it a few times (we can see in the headers that the page is NOT being cached) - i.e. press F5 ten times - and then we log out. All in Chrome.

  2. We browse to the URL using Firefox (never visited the website before on firefox) and we can see the page (we are not logged in).

This obviously should not happen at all.

The same page is not accessible from other computers in our office. We are using a stock standard install of Kubuntu 16.04.

tractorcow commented 6 years ago

We are actually looking at this at https://github.com/silverstripe/silverstripe-framework/pull/8086#discussion_r193092449.

Our suggestion is that any session instantiation will result in cache control being set to private; That includes CSRF and user login.

dhensby commented 6 years ago

looks like this is solved in core, then?

Actually, I don't see how it can be related, because if FF browser has never been before but sees a cached page, then this sounds more like a duplicate of #70?

sunnysideup commented 6 years ago

We looked at this for ages and it definitely had some weird caching going on (perhaps ISP caching)?