search

tractorcow / silverstripe-dynamiccache

Simple on the fly caching of dynamic content for Silverstripe
39 stars 27 forks source link

this module does not work in 3.7.0? #73

Closed sunnysideup closed 5 years ago

sunnysideup commented 6 years ago

image

tractorcow commented 6 years ago

Oh no that's a problem. Maybe DynamicCache needs to build a request instance.

sunnysideup commented 6 years ago

what I dont understand, and of course I am a nincompoop, is why 3.7 can break the module so badly when there are not API breaking changes in a minor release AFAIK.

Btw, did I mention this module rules BIG TIME?

tractorcow commented 6 years ago

Ok well I had better make a new version of this module for 4.x asap.

tractorcow commented 6 years ago

what I dont understand, and of course I am a nincompoop, is why 3.7 can break the module so badly when there are not API breaking changes in a minor release AFAIK.

We take a lot of risks, but we catch a lot more errors that were once silent errors in the past. We need to get better at semver; We are still quite liberal with the rules...

dhensby commented 6 years ago

works fine for me?

christopherdarling commented 6 years ago

Have you updated your .htaccess or still pointing to framework/main.php?

I've partially fixed this in my fork but another issue occurred after fixing this one

On Thu, 19 Jul 2018, 23:04 Daniel Hensby, notifications@github.com wrote:

works fine for me?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tractorcow/silverstripe-dynamiccache/issues/73#issuecomment-406428611, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK3d0KLIZRlvkm89iYGAhdYdepaNxm9ks5uIQJcgaJpZM4Uh6Ya .

dhensby commented 6 years ago

whoops - good point - I pointed at framework/main.php because this starts the session on every request

dhensby commented 6 years ago

gah - I hate adding exceptions in minor releases! this is so annoying :/