search

tractorcow / silverstripe-dynamiccache

Simple on the fly caching of dynamic content for Silverstripe
39 stars 27 forks source link

FIX compatibility with SS 3.7.0 #77

Closed christopherdarling closed 5 years ago

christopherdarling commented 5 years ago

Fixes #73

Works in PHP 5.6 and 7.2 fixes the problem raised in #73 (Request not found) but there are some other PHP7.2 related issues, these are:

  1. Object which I've fixed in https://github.com/tractorcow/silverstripe-dynamiccache/compare/master...christopherdarling:feature/php7.2
  2. warning for session_cache_limiter which is called after session_start in DynamicCache::run() I'm yet to fix this though.
tractorcow commented 5 years ago

Good fix thanks.

jonom commented 5 years ago

Thank you @christopherdarling! @tractorcow could you please tag a release for this? 😄

christopherdarling commented 5 years ago

Just a heads up, while this improves things, I've come across issues with this when viewing in Draft mode. because I've created a mock Controller, there's no Request so Versioned::choose_site_stage() fails. Working on a fix and will update here when ready - unless someone beats me to it ;-)