search

tractorcow / silverstripe-dynamiccache

Simple on the fly caching of dynamic content for Silverstripe
39 stars 27 forks source link

Sessions not being created - cannot login to website #83

Open jonom opened 5 years ago

jonom commented 5 years ago

Running master on SS3.7 / PHP5.6 I'm unable to login to the website. Reverting this commit seems to fix the issue. I tried to follow the code and understand why this is the case but I couldn't work it out 🤷‍♂️. As noted in the pull request it would seem to follow the same pattern as main.php but seems something is getting lost along the way.

To replicate, make sure dynamic caching is activated in .htaccess, delete cookies for the website (if PHPSESSID exists already login will work), then try to access a protected URL like /admin. After filling out the log in form I'm simply redirected back to the same form, unfilled.

mlewis-everley commented 4 years ago

I can confirm that I am seeing this as well on a SS 3.7 / PHP 7.1 install.

tractorcow commented 4 years ago

We can revert that commit maybe.