Hi, thank you for developing and maintaining the google-glog.
I found the bug that --enable-frame-pointers configure option doesn't work
properly.
The following is the step to reproduce and the patch that fixes the problem is
attached.
* What steps will reproduce the problem?
1. ./configure --enable-frame-pointers
* What is the expected output? What do you see instead?
The software should be compiled without -DNO_FRAME_POINTER, but not.
* What version of the product are you using? On what operating system?
0.3.0
* Please provide any additional information below.
This patch fixes the problem. The misuse of AC_ARG_ENABLE caused the bug.
Index: configure.ac
============================================================
=======
--- configure.ac (revision 76)
+++ configure.ac (working copy)
@@ -84,7 +84,7 @@
AC_ARG_ENABLE(frame_pointers,
AS_HELP_STRING([--enable-frame-pointers],
[On x86_64 systems, compile with -fno-omit-frame-pointer (see INSTALL)]),
- enable_frame_pointers=no)
+ , enable_frame_pointers=no)
AC_COMPILE_IFELSE([AC_LANG_PROGRAM(, [return __x86_64__ == 1 ? 0 : 1])],
[is_x86_64=yes], [is_x86_64=no])
AM_CONDITIONAL(ENABLE_FRAME_POINTERS, test "$enable_frame_pointers" = yes)
Please commit the patch if it seems ok to you.
Thanks in advance.
Kazuki
Original issue reported on code.google.com by kazuki.o...@gmail.com on 15 Apr 2010 at 8:06
Original issue reported on code.google.com by
kazuki.o...@gmail.com
on 15 Apr 2010 at 8:06