search

tradecraftio / tradecraft

Tradecraft integration/staging tree https://tradecraft.io/download
Other
13 stars 9 forks source link

Remove HTTP REST protocol #10

Open maaku opened 5 years ago

maaku commented 5 years ago

In the interest of minimizing the attack surface of the tradecraft daemon, the HTTP REST protocol added in bitcoin/0.10 should be removed. The functionality that it provides is available either from JSON-RPC or from the p2p protocol, and if a REST interface is required it should be done as a separate middleware layer that translates REST requests into JSON-RPC or p2p messages--something that would be trivially simple to implement with python-bitcoinlib and flask.

maaku commented 5 years ago

Removed from the rebase-0.10 project, since for the moment it is probably better to include the REST API until something better is written. This issue should be used to track replacement of this feature.