search

tradecraftio / tradecraft

Tradecraft integration/staging tree https://tradecraft.io/download
Other
13 stars 9 forks source link

Revert a95b1199: Follow SI standard for thin spaces, not arbitrary design aethetics #11

Closed maaku closed 5 years ago

maaku commented 5 years ago

The SI standard describes digit-separating thin spaces as an optional visual cue, but it says nothing of using thin spaces for the whole part of the number only, and no spaces for the decimal part. This is an arbitrary design decision based on aesthetics. We should conform with international standards instead: either revert the removal of thin-space digit separators for the decimal portion of amounts or remove digit-separators entirely.

maaku commented 5 years ago

This proved trivial to revert. The latest version of the rebase-0.10 branch restores the intermediate behavior of having thin-spaces as digit separators both before and after the decimal point.

maaku commented 5 years ago

Actually upon testing I ran into an issue with Qt not displaying narrow spaces correctly. I think this might be related to the version of Qt that version 0.10 ships with. For now I've added a commit which restores thin spaces to the decimal portion, then one which removes thin spaces entirely. In later releases let's review this and see if the issue is fixed.

I'm reassigning this ticket to 0.11.

maaku commented 5 years ago

Confirmed this issue is resolved in v11.