Re 001a53d7: Assert on `GetRandBytes` failing to gather entropy

tradecraftio / tradecraft

Tradecraft integration/staging tree https://tradecraft.io/download

Other

13 stars 9 forks source link

Re 001a53d7: Assert on `GetRandBytes` failing to gather entropy #12

Closed maaku closed 5 years ago

maaku commented 5 years ago

GetRandBytes currently (in bitcoin/0.10) returns an error code indicating whether random bytes were actually generated. This error code should currently be checked in all the places GetRandBytes is called, but GetRandBytes should just error out the entire program if this fails given the disastrous security implications of failing to get random data and continuing operation. See bitcoin PR #4400.

maaku commented 5 years ago

Ah, apparently Wladimir already fixed this in commit 65e3a1e762. Somehow I missed the follow-up fix when reviewing the commit log.

The easiest fix is the one you don't have to do!