In the rebase to 0.10, it appears that some code newly introduced in the bitcoin change set was not updated to handle demurrage properly. This results in, among other things, watch-only balances not being adjusted for demurrage. The consequences for UI and wallet might be worse than just that, but there shouldn't be any ramifications for consensus code at least.
In fixing this, we should investigate making nValue of CTxOut and CCoins protected and accessed by getters and setters, so that any new code in future releases that touches these fields will be automatically found during compilation.
maaku
commented
5 years ago
In the rebase to 0.10, it appears that some code newly introduced in the bitcoin change set was not updated to handle demurrage properly. This results in, among other things, watch-only balances not being adjusted for demurrage. The consequences for UI and wallet might be worse than just that, but there shouldn't be any ramifications for consensus code at least.
In fixing this, we should investigate making
nValueofCTxOutandCCoinsprotected and accessed by getters and setters, so that any new code in future releases that touches these fields will be automatically found during compilation.