tradecraftio / tradecraft

Tradecraft integration/staging tree https://tradecraft.io/download
Other
13 stars 9 forks source link

"Unrecognized version" warning on v12.1 #44

Closed maaku closed 5 years ago

maaku commented 5 years ago

Calling getmininginfo reports in the error field "Warning: Unknown block versions being mined! It's possible unknown rules are in effect". This warning also shows up in the debug log whenever the tip is extended. This is because bit 28 must be force-set until 2 Oct 2019, but there is no corresponding version bits entry for this bit during that timeframe. The following code is what detects and generates this warning:

https://github.com/tradecraftio/tradecraft/blob/1a9589cd87a08dd9cd1a0aa0811fc11c92055e8b/src/main.cpp#L2617

It ought to be changed to cover only the range VERSIONBITS_NUM_BITS - 1 until signaling times out on 2 Oct 2019.

So far as I know this warning is purely cosmetic and does not affect node operation in any way. Nevertheless to prevent user complacency with respect to this very serious warning the bug ought to be fixed and a point release made to solve this one issue.

Thanks to Fredrick Bodin for finding and reporting this issue.

maaku commented 5 years ago

Fixed in v12.1.1.