maaku
commented
4 years ago The version bit 28 stuff is fixed in both the v12 and v13 branches. Freicoin/Tradecraft no longer warns about this specific bit being set during the BIP66 activation window after activation.
However in the mean time the network has transitioned to a majority of miners using overt ASICBoost capable mining hardware. This hardware uses stratum version-rolling extensions to set unused bits, and these unexpected bit settings are causing the exact same warnings to be issued, so the problem persists. I'm keeping this issue open and modifying the title to track this new issue, since it is essentially the same problem.
PR #72 surpasses the warning entirely, which is enough to make this not release blocking. While I haven't looked into it yet, I expect that bitcoin solves this in more recent upstream versions, since they would be dealing with exactly the same problem. So for the moment suppressing the warning is enough, and this should be revisited on each rebase to newer upstream releases.
Since October 2nd freicoin daemons have been reporting an unrecognized new rule has activated. This is because bit #28 was forced set as a result of a prior soft-fork until that date. The version bits warning code was also disabled, but only until this date. Now it is active and looking back, it sees successful activation as per the BIP9 rules.
Thankfully this causes no known issues, and the p2pool mining software is ignoring the warning rather than treat it as an error. But the versionbits code should be modified to ignore bit#28 signalling during this period.