Remove CSV and CLTV script verification flags, remove NULLDUMMY

tradecraftio / tradecraft

Tradecraft integration/staging tree https://tradecraft.io/download

Other

13 stars 9 forks source link

Remove CSV and CLTV script verification flags, remove NULLDUMMY #58

Closed maaku closed 5 years ago

maaku commented 5 years ago

This PR cleans up the script verification flags. SCRIPT_VERIFY_CHECKLOCKTIMEVERIFY and SCRIPT_VERIFY_CHECKSEQUENCEVERIFY are removed as CLTV and CSV are automatically enabled in witness scripts and are not safe to enable otherwise (since we use the variants which drop arguments from the stack).

Additionally, the NULLDUMMY feature is removed entirely as Tradecraft supports the conflicting MULTISIG_HINT flag instead.

maaku commented 5 years ago

Made against the wrong branch. Closing.