Change dummy value in CHECKMULTISIG to be bitmask of keys used

tradecraftio / tradecraft

Tradecraft integration/staging tree https://tradecraft.io/download

Other

13 stars 9 forks source link

Change dummy value in CHECKMULTISIG to be bitmask of keys used #6

Closed maaku closed 5 years ago

maaku commented 5 years ago

Commit 638018082 rejects non-null values for the extra popped field of CHECKMULTISIG. This was a dumb decision by bitcoin--we should instead require that this field be an (inverted?) bitmask of the public keys used, so that no guessing is required and batch validation can be used.

maaku commented 5 years ago

The referenced PR #25 adds this capability, in a more general change that requires all signature checks to pass.

maaku commented 5 years ago

As this remained the only technical issue blocking 0.10, and there is still significant work to be done, REQUIRE_VALID_SIGS is pushed to rebase/0.11. The only requirement for rebase/0.10 is that NULLDUMMY is not added to the STANDARD_SCRIPT_VERIFY_FLAGS. I'm going to open a new separate PR to make this change, and then reassign this issue and #25 to the rebase/0.11 project.

maaku commented 5 years ago

NULLDATA removed from standard flags in PR #28. Changing assigned project to rebase/0.11.

maaku commented 5 years ago

v11 released without this; bumping to v12