tradecraftio / tradecraft

Tradecraft integration/staging tree https://tradecraft.io/download
Other
13 stars 9 forks source link

[Stratum] Disable server by default, and fix RPC tests. #73

Closed maaku closed 4 years ago

maaku commented 4 years ago

For security reasons, it is preferable to have the stratum server disabled by default. It's just one less potential attack interface. This also fixes the rpcbind RPC test. While we're at it, this PR also fixes the stratum port assignment for RPC tests, so that multiple nodes don't conflict over the same port. Not that this matters, since there aren't any stratum RPC tests yet and it is disabled by default, but it'll prevent a potential bug once we do write some stratum tests.