tradecraftio / tradecraft

Tradecraft integration/staging tree https://tradecraft.io/download
Other
13 stars 9 forks source link

Report invalid nTime-rolling to the main log, not the stratum log #88

Closed maaku closed 4 years ago

maaku commented 4 years ago

After activation of merge-mining, nTime-rolling on the native chain is no longer allowed. Miners should be configured to not use stratum's time rolling feature when mining the native proof-of-work header. Any invalid shares which used nTime-rolling should be reported to the log so that the user is aware of the misconfiguration and the reason for the rejected shares.

The mining server was previously reporting this error, but only when -debug=stratum was set, which also generated a ton of stratum protocol status messages to sort through. This fix makes the error reported to the main log.