search

trader-xyz / nft-swap-sdk

Ethereum's missing p2p NFT and token swap library for web3 developers. Written in TypeScript. Powered by 0x.
https://swapsdk.xyz
MIT License
219 stars 83 forks source link

NFT <> NFT Trades are not supported by V4 SDK #102

Closed wizardlabsxyz closed 1 year ago

wizardlabsxyz commented 1 year ago

Hello! I'm trying to test out the NFT <> NFT trades with V4 and it looks like that isn't supported yet. I understand from the error messages I receive that I should use V3 instead for this.

Now that I'm trying to use V3 SDK I find that the addresses.json of V3 SDK does not include chainId 5.

I would like to use a testnet with NFT <> NFT trades and since rinkeby is deprecated it would be awesome if you could update the addresses.json to include testnet Goerli (chain 5).

Another question regarding Goerli and V3. Will the V3 version of the SDK work with the protocol contracts deployed to Goerli?

jinsley8 commented 1 year ago

The 0x contracts aren't deployed to newer Ethereum testnets.

You're better off getting it working with Polygon since it's lower cost then make adjustments for Eth mainnet and run a few tests with that. Although gas is expensive.

johnrjj commented 1 year ago

Yeah, the 0x core team has not deployed v3 to any current (goerli, sepolia) testnets.

unfortunately the v3 contracts are quire cumbersome to deploy, although I can definitely try -- I have the repo locally

wizardlabsxyz commented 1 year ago

Thanks for the replies, I decided to work with polygon mumbai testnet for now since V3 is deployed there. While I have you guys here though... Do we have any idea on when V4 will support NFT <> NFT trades?

johnrjj commented 1 year ago

Not sure: re NFT<>NFT swaps. That's something I've been requesting. I'm unfortunately not involved with the core team and don't have much visibility into the protocol roadmap at the moment. I've been trying to get 0x Labs to put it on the roadmap for a bit now. I think it's worth proposing something on the governance forum now that governance has been revamped -- I've been meaning to do it.

wizardlabsxyz commented 1 year ago

If I can support this effort in anyway please do let me know. I have a client that is invested in this software and we will need V4 to support NFT <> NFT trades very soon.