trader-xyz / nft-swap-sdk

Ethereum's missing p2p NFT and token swap library for web3 developers. Written in TypeScript. Powered by 0x.
https://swapsdk.xyz
MIT License
219 stars 83 forks source link

V4 Custom Expiry #111

Open Azraellx opened 9 months ago

Azraellx commented 9 months ago

By default order expiry is set to 30 days. While building an order, I've tried to add an expiry field that is set to 24hrs (in milliseconds). I see this being set correctly while signing the order on the maker side—but while attempting to execute on the taker side the transaction fails. My hypothesis is it has something to do with the nonce this tool auto generates, not expecting a change to expiry