search

trader-xyz / nft-swap-sdk

Ethereum's missing p2p NFT and token swap library for web3 developers. Written in TypeScript. Powered by 0x.
https://swapsdk.xyz
MIT License
219 stars 83 forks source link

BuildOrderAdditionalConfig in V3 is not documented #87

Open rico-bee opened 2 years ago

rico-bee commented 2 years ago

  1. It seems V4 doesn't support NFT < - > NF swap, so I have to use SwapSDK V3 if I need to do NFT <-> NFT?

  2. For V3, it seems the way to specify the fee components will be passing a BuildOrderAdditionalConfig to buildOrder function. However I cannot see any example / doc about how to use this parameter. can anyone share some experiences with the fee configuration ? any help will be much appreciated. thanks

johnrjj commented 2 years ago

It seems V4 doesn't support NFT < - > swap, so I have to use SwapSDK V3 if I need to do NFT <->?

which swap do you mean? NFT<>ERC20? or NFT<>Bundle?

rico-bee commented 2 years ago

NFT <-> NFT. for example: https://docs.swapsdk.xyz/readme-1#example-1-nft-less-than-greater-than-nft-swap

jinsley8 commented 2 years ago

@rico-bee the parameters are here on line 94 - https://github.com/trader-xyz/nft-swap-sdk/blob/8b3c3ebfa868cbbb1beb59f49521b956faed0201/src/sdk/v3/INftSwapV3.ts

Better descriptions of parameters here: https://github.com/0xProject/0x-protocol-specification/blob/master/v3/v3-specification.md#order-message-format