Closed acalejos closed 3 months ago
@acalejos Looks interesting. I implemented jitconfig into Cilicon to try it out. My main concern is that there's no "replace" option that could overwrite already existing runners with the same name and will throw an error. One could mitigate this by mixing the name with a uuid, as you did, but I'm concerned about offline runners piling up in runner groups and don't know if they will auto-expire after a while.
@acalejos After testing jitconfig, I have decided to not publish the implementation as I simply don't see the benefit except for being able to use PATs instead of Apps. Please let me know if I'm missing something.
First, let me start by saying thank you for this project! I've searched far and wide for a simple solution to this very problem, and had my first successful run using a self-hosted solution with a Mac Mini for my project
Since the newest release supports targeting the /repos endpoint and individual's projects rather than organizations, it might make sense to support the JIT config setup for Github Actions Runners. I ended up using a custom script provision using this endpoint along with
./run.sh --jitconfig {jitconfig}
option.So basically the command would look like:
You already have access to most of these with the config options as they are currently. According to the docs, it also works with GitHub apps, so maybe it could even replace the current implementation (not confident on that).
I can try my hand at doing it myself, but wanted to get your opinion on its inclusion first.
Thanks again!