search

traderjoe-xyz / joe-core

📝 Main contracts for Trader Joe
MIT License
154 stars 88 forks source link

No deposit fee #117

Closed cryptofish7 closed 1 year ago

cryptofish7 commented 2 years ago

In this PR I add feature to sJOE that exempts EOAs holding a Smol Joe from paying the deposit fee.

cryptofish7 commented 2 years ago

Small nits. Please add a non zero check at L168 and L169 so it stops spamming the multi sig with transfer(0). (it will also decrease gas cost)

What do you mean by this?

0x0Louis commented 2 years ago

I mean to add a:

if (amount > 0) token.safeTransferFrom(msg.sender, to, amount);

at L168 and 169 for the 2 different transfers