search

tradewright / tabcontrol-extra

An improved TabControl for Windows Forms (.Net)
Other
33 stars 8 forks source link

Issue with TabClosing event #2

Closed gmattis closed 5 years ago

gmattis commented 5 years ago

I'm currently using your custom control for a private software (and it is perfect by the way), but I ran into an issue dealing with the TabClosing event. This event is currently raised after the tab is closed, instead of being raised before the tab is closed. It seems like moving the if (this.TabClosing != null) statement at the top of the OnTabClosing method (in TabControlExtra.cs) solves the issue. May you make a commit solving the problem? Thank you for your great work!

rlktradewright commented 5 years ago

Ok, I'll look into it. Not immediately though...

rlktradewright commented 5 years ago

You're right, there's definitely a fault there, well spotted! I'll try to commit a fix over the weekend.

gmattis commented 5 years ago

Thank you!