search

trading-peter / chart-elements

Chart.js as Polymer Elements
https://robdodson.github.io/chart-elements
267 stars 70 forks source link

Fix sizing and tests #41

Closed trading-peter closed 8 years ago

trading-peter commented 8 years ago

I did a woopsie daisy in my last pr. I used absolute positioning/stretching on the canvas wrapping div to make the chart use the whole size of the chart element. However, this causes elements not to show up when no specific size is set. See #40.

This is what you get without proper testing... I fixed the tests (hopefully). B/c of API changes in Chart.js 2.0.0 they weren't able to check if the chart actually has dimensions after rendering. I can't run the sauce test, b/c I don't have an account.

trading-peter commented 8 years ago

@robdodson can you run the tests on sauce?

trading-peter commented 8 years ago

Damn it, you're right. GitKraken fooled me... I'll close this one an make a new, clean, shiny pr.