search

trading-peter / chart-elements

Chart.js as Polymer Elements
https://robdodson.github.io/chart-elements
267 stars 70 forks source link

Fix initial sizing and tests. #42

Closed trading-peter closed 8 years ago

trading-peter commented 8 years ago

Absolute fitting caused chart to not show up without explicit width and height. Tests weren't working with the new API of Chart.js. Also updated chart options in the tests. Afaik all charts now use the same dataset based data structure, so I removed the basic-data-chart.html test file. It tested basically the same stuff. Curious if you guys agree?

robdodson commented 8 years ago

oh yeah that seems like it could be a way better approach. Are you able to update the PR to use that?

trading-peter commented 8 years ago

Yep, will do that. But not today. (It's 11pm in Germany)

trading-peter commented 8 years ago

Now using onComplete to finish the tests. Works like a charm in my testing. But as said, I don't own a saucelaps account.

robdodson commented 8 years ago

Just started reviewing :)

:octocat: Sent from GH.

trading-peter commented 8 years ago

At your service if you have questions, critic, recommendations, my master 😉

robdodson commented 8 years ago

@pkaske hah thanks :) Just trying to get my sauce account working after having neglected it for so long!

robdodson commented 8 years ago

Local tests work. Not sure what's up with Sauce Labs but we can deal with that another day :D