search

trading-peter / chart-elements

Chart.js as Polymer Elements
https://robdodson.github.io/chart-elements
267 stars 70 forks source link

chart-doughnut documentation contains an error #64

Closed jibbo closed 5 years ago

jibbo commented 7 years ago

Hi, thanks a lot for your work, I just found out a small error in the documentation: this page indicates that in order to use the doughnut chart you should add the tag with the values attribute, like this:

<chart-doughnut values="{{data}}"></chart-doughnut>

But it won't work. In fact, it should be:

<chart-doughnut data="{{data}}"></chart-doughnut>

Please, mind the attribute, which changed from values to data. Of course I can fix it and create a pull request if you want, but I thought it was better to let you know first.

trading-peter commented 7 years ago

Hi @jibbo, one of the maintainers here. You're right, the docs are wrong. A PR would be super welcome if you have time. Thanks for reporting :smiley: