tradingview / charting-library-examples

Examples of Charting Library integrations with other libraries, frameworks and data transports
MIT License
1.33k stars 744 forks source link

Update min library version in examples #260

Closed icastillejogomez closed 2 years ago

icastillejogomez commented 2 years ago

Checklist

Describe the bug

When I run the react-typescript error this error occurs.

/Users/nacho/Code/charting-library-examples/react-typescript/src/components/TVChartContainer/index.tsx
(56,9): Property 'container' is missing in type '{ symbol: string; datafeed: any; interval: Nominal<string, "ResolutionString">; container_id: string | undefined; library_path: string; locale: LanguageCode; ... 8 more ...; studies_overrides: StudyOverrides | undefined; }' but required in type 'ChartingLibraryWidgetOptions'.

To Reproduce

Steps to reproduce the behavior:

  1. Clone the repo
  2. Go to 'react-typescript' folder
  3. Run yarn to install dependencies
  4. Copy chartin_library folder inside charting_library repo to src and public folders
  5. Copy datafeed folder to public folder
  6. Run command yarn start
  7. See error in your browser

Expected behavior

See the demo

Screenshots Captura de pantalla 2021-12-13 a las 0 08 24

Additional context

❯ node -v
v16.3.0
❯ npm -v
8.1.3
timocov commented 2 years ago

Please update your charting library version.

icastillejogomez commented 2 years ago

I'm using the latest version available @timocov

timocov commented 2 years ago

@icastillejogomez what version do you use?

icastillejogomez commented 2 years ago

@timocov The current version is: CL v20.033 (internal id 9df149da @ 2021-11-17T10:20:51.511Z)

timocov commented 2 years ago

Sorry, I misunderstood your issue, my bad. We need to update our samples to make them work correctly with the latest versions.

For now, locally you can try to replace container_id with container here.

timocov commented 2 years ago

We just updated most of our examples in #269 so I'm going to close this issue for now. Let me know if you need any help or clarification.