Charting Library with Sveltekit(svelte) example

tradingview / charting-library-examples

Examples of Charting Library integrations with other libraries, frameworks and data transports

MIT License

1.32k stars 744 forks source link

Charting Library with Sveltekit(svelte) example #356

Closed Razz19 closed 10 months ago

Razz19 commented 11 months ago

I am currently developing an app with SvelteKit and using the charting_library for charts. Since I noticed that there is no existing Svelte example for integrating the charting_library, I am eager to contribute one to the project.

Razz19 commented 10 months ago

Hey I've pushed the suggested changes check them out here [fbc1d4e]

Here's the list of the changes:

[x] copy_charting_library_files updated
[x] Datafeed arguments added
[x] Font changed
[x] Credit section added to README

SlicedSilver commented 10 months ago

The example appears to expand beyond the height of the window (and is thus scrollable). It would be better to adjust the css and html so that the page isn't scrollable. You can look at the vuejs3 example to see a possible way to achieve this. Alternatively, I believe that removing the top header which mentions the version number would solve this as well.

Razz19 commented 10 months ago

check out my latest commit [da6a2aa] here is the list of changes :

[x] TVChartContainer <html> tag removed
[x] Scroll issue fixed (I didn't remove the version section, lmk if you want me to remove it!)

Razz19 commented 10 months ago

Hey, no worries, I've committed all suggestions, let me know if there's any other issue ;)