Build is broken: Puppeteer download URL access denied

tradingview / lightweight-charts

Performant financial charts built with HTML5 canvas

https://www.tradingview.com/lightweight-charts/

Apache License 2.0

9.13k stars 1.58k forks source link

Build is broken: Puppeteer download URL access denied #1678

Open schoeth opened 3 weeks ago

schoeth commented 3 weeks ago

Lightweight Charts™ Version: 4.1.4 - 4.2.0

Steps/code to reproduce:

A simple

npm install

gives me the following error:

lwc_build_error_1

If i comment out the following line, it works:

lwc_build_error_2

This is what the browser shows at this URL:

lwc_build_error_3

I don't know what that this URL should provide, but just in case that this URL is just restricted, pls. find another way so that everyone is able to do a build.

illetid commented 3 weeks ago

try to clean npm cache first npm cache clean --force, and in case you are not planning to run e2e tests, then as suggested in the error message set the PUPPETEER_SKIP_DOWNLOAD environment variable to true before the installing packages PUPPETEER_SKIP_DOWNLOAD=true npm install

schoeth commented 3 weeks ago

Thanks for your Answer! The reason why i consider the build as broken: In my understanding a build in a public repository is working, if the public (esp. new users) checks out the repository, enters the documented commands, and the build will be done without errors. But here the public will be sent knowingly over a bunch of deprecation-messages (even with memory-leak-warnings [inflight]), until the thing fails with error-messages.

So i see 3 ways to achive immediate successful builds for the public / new users:

put the stuff to be downloaded on a public site (as the repostory is),
change the "the public has to opt-out after failed with error" to "the perimitted ones have to opt-in", or
write the necessary opt-out commands into at least the BUILDING.md

Just my 2 cents ;)