search

tradle / rn-nodeify

hack to allow react-native projects to use node core modules, and npm modules that use them
MIT License
615 stars 112 forks source link

Update react-native-tcp to Support react-native >= 0.40.0 #37

Closed mcarter00 closed 7 years ago

mcarter00 commented 7 years ago

rn-nodeify was overriding my version of react-native-tcp with an older version (2.0.4) when running rn-nodeify --install stream,process,util,net --hack, which was problematic because react-native >= 0.40.0 is incompatible with 2.0.4 because of this deprecation: http://tekkie.ro/quick-n-dirty/support-react-native-0.40-ios-headers/

I have tested my branch by npm installing it into my project.

mcarter00 commented 7 years ago

FYI @aprock

mvayngrib commented 7 years ago

@mcarter00 lgtm, though maybe rn-nodeify shouldn't override existing deps at all?

mcarter00 commented 7 years ago

Ya, fair point, I'll try that instead...

cbjs commented 7 years ago

any updates

mvayngrib commented 7 years ago

@mcarter00 thanks. I've also added the --overwrite flag, so that by default existing versions are not clobbered

cbjs commented 6 years ago

please update npm version

mvayngrib commented 6 years ago

republished as 8.0.0