search

tradle / rn-nodeify

hack to allow react-native projects to use node core modules, and npm modules that use them
MIT License
615 stars 112 forks source link

Support npm5 #40

Closed staltz closed 7 years ago

staltz commented 7 years ago

npm5 installs modules and changes their package.json::version field to be something like 

  "version": "https://registry.npmjs.org/rn-nodeify/-/rn-nodeify-7.0.1.tgz",

instead of

  "version": "7.0.1",

This commit adds support for that first type of string but also supports npm4.

mvayngrib commented 7 years ago

@staltz i thought i'd see you here eventually, after your visit to asyncstorage-down

looks good, though u prob need a null check. exec() may return null, then exec(...)[1] will throw an error

staltz commented 7 years ago

Oh right, sorry for that. Will fix.

staltz commented 7 years ago

Updated the PR

mvayngrib commented 7 years ago

thanks!