tradle / rn-nodeify

hack to allow react-native projects to use node core modules, and npm modules that use them
MIT License
615 stars 112 forks source link

Cleanup crypto code in shim.js #54

Closed jd20 closed 6 years ago

jd20 commented 6 years ago

Cleaning up the crypto stuff in shim.js. Getting rid of the sha256 algo hack, since it no longer seems necessary with browserify-sign 4.0.0 and later. Requiring a newer version of react-native-crypto, which populates window.getRandomValues() function for us (and has a bug fix to that function for non-Uint8 Typed Arrays). Also adding a reminder in README to link libraries.

Note: This has to be merged after the react-native-crypto PR is merged, otherwise react-native-crypto 2.1.0 won't exist.

mvayngrib commented 6 years ago

thanks!