Conditionally require crypto module in shim.js

tradle / rn-nodeify

hack to allow react-native projects to use node core modules, and npm modules that use them

MIT License

619 stars 112 forks source link

Conditionally require crypto module in shim.js #57

Closed jd20 closed 6 years ago

jd20 commented 6 years ago

Fixes the issue discussed here: https://github.com/tradle/react-native-crypto/pull/22. Basically, sometimes we need to require('crypto') before anything else, and shim.js is the best place to do that.

mvayngrib commented 6 years ago

@jd20 could you add a comment in the commit as to why it has to be a dynamic require? Just for it to be easy to remind ourselves of the reason in the future

jd20 commented 6 years ago

Sure, just added it.

mvayngrib commented 6 years ago

@jd20 awesome, thanks! Released in 8.3.0