Closed mactkg closed 6 years ago
@mactkg thanks for the PR! However, according to npm docs, username/repo#commitish is a valid github dependency url. I do see an issue with pacote that might be related, about misreported errors. Can you check why pacote actually throws this error? Because "Non-registry package missing package.json" is obviously not true. There's definitely a package.json in react-native-http :)
Thanks for your reply! Hmm, the syntax seems to be valid. There is one more thing that bothers me. I'm wondering if a repo url in a package.json of react-native-http is wrong.
The line is here: https://github.com/tradle/react-native-http/blob/834492dbc792b1dec8ec8f0a1c9671f640339f01/package.json#L24 Should a url of the line be https...?
Thanks!
2018年2月3日(土) 23:13 Mark Vayngrib notifications@github.com:
@mactkg https://github.com/mactkg thanks for the PR! However, according to npm docs https://docs.npmjs.com/files/package.json#github-urls, username/repo#commitish is a valid github dependency url. I do see an issue https://github.com/npm/npm/issues/19466#issuecomment-360127282 with pacote that might be related, about misreported errors. Can you check why pacote actually throws this error? Because "Non-registry package missing package.json" is obviously not true. There's definitely a package.json in react-native-http :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tradle/rn-nodeify/pull/62#issuecomment-362811369, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK48vGcYMBaFwnJ-uRLd8bHF6kmHz5-ks5tRGl2gaJpZM4R4EUT .
@mactkg you're right, that url is all kinds of wrong. It should be https://github.com/tradle/react-native-http (the repo location moved at some point, i guess i forgot to change this field)
okay, so this repo doesn't cause a problem! I'll close this PR later. (I'm out now, so I close later. It's ok if anyone can close this)
2018年2月3日(土) 23:28 Mark Vayngrib notifications@github.com:
@mactkg https://github.com/mactkg you're right, that url is all kinds of wrong. It should be https://github.com/tradle/react-native-http (the repo location moved at some point, i guess i forgot to change this field)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tradle/rn-nodeify/pull/62#issuecomment-362813758, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK48valakYGXAtDw7YN0aJfTi3nKxMmks5tRG0ngaJpZM4R4EUT .
Fix stacking issue while installing react-native-http
Error Log: