search

tradle / rn-nodeify

hack to allow react-native projects to use node core modules, and npm modules that use them
MIT License
619 stars 112 forks source link

Take "browserify" field into consideration #7

Closed vespakoen closed 8 years ago

vespakoen commented 8 years ago

https://github.com/mvayngrib/rn-nodeify/blob/bac7668c00666cb9704b8fd871633d938487d6f8/cmd.js#L211

Should look something like:

var orgBrowser = pkgJson.browser || pkgJson.browserify || {};

Some packages are still relying on the browserify field, "shoe" for example:

https://github.com/substack/shoe/blob/5b6edae990ac5919dd78d966a4b99b05b69f6554/package.json#L6

If rn-nodeify would consider the "browserify" field, the correct mappings will end up in the "browser" field and the react-native package will accept it happily.

vespakoen commented 8 years ago

Fixed!