search

tradr-project / tensorflow_ros

Project moved to tensorflow_ros_cpp
https://github.com/tradr-project/tensorflow_ros_cpp
26 stars 10 forks source link

Remove a dependency that can be addressed in the upstream than tensorflow_ros #9

Closed 130s closed 6 years ago

130s commented 6 years ago

Addressing https://github.com/tradr-project/tensorflow_ros/pull/7#commitcomment-29363522

Technically I could just reset the commit that added swig instead of adding another commit like in this PR to remove it, but I prefer keeping the history :) But it's up to the maintainers.

(Also on a separate note, would you mind opening PRs for any change in the future instead of directly committing? That way people subscribing get notifications (we keep our fork version of your repo and want to sync as much, so getting notified is kind of crucial to us), and having PR pages makes it much easier to reference to the decision made and keep track of it. In the end it's up to the maintainers though. Thanks.)

peci1 commented 6 years ago

Hey, I had to move this project to tensorflow_ros_cpp, because there already has been a package named tensorflow_ros from somebody else. Please, update your references (it should be sufficient to change the git remote address and pull from master). I'm sorry for the difficulties.

As for your second request - local development through PRs isn't very convenient for me. Try https://gitpunch.com/ , I'm actively using it and it works nicely. It alerts you about new tags/releases, which I do with every new version ;)

130s commented 6 years ago

This is reopened at https://github.com/tradr-project/tensorflow_ros_cpp/pull/1

I see that you prefer committing directly, which is fine as I mentioned. Though one point I forgot is that opening pull request per every change is also getting more standard.