search

traefik-plugins / traefik-jwt-plugin

Traefik plugin which checks JWT tokens for required fields. Supports Open Policy Agent (OPA) and signature validation with JWKS
Apache License 2.0
98 stars 34 forks source link

Ignore capitalization of Authorization prefix #52

Closed lvijnck closed 1 year ago

lvijnck commented 1 year ago

Hi team,

First off all, thanks for this great plugin!

I am working on a project to implement a reverse proxy for various external backend services (which I unfortunately do not control). I came to the realisation that some of these services use 'BEARER' or 'bearer' as the Auth header prefix, which is compatible with the Traefik middleware, hence raising this small PR.

Can also toggle this behind a feature flag if relevant, happy to expand PR as required.

@eshepelyuk tagging for visibility.

lvijnck commented 1 year ago

Hi @eshepelyuk updated git commit message and expanded unit tests (not sure if this is the best setup, so let me know if you want any changes).

lvijnck commented 1 year ago

Plz rebase and squash into single commit. As soon as build is green, ready to merge.

Done! Workflow seems to be awaiting approval.

eshepelyuk commented 1 year ago

Thanks for contributing. New version will be available soon.

lvijnck commented 1 year ago

@eshepelyuk is the release process automated, or is there a need to wait till a given date?

eshepelyuk commented 1 year ago

@eshepelyuk is the release process automated, or is there a need to wait till a given date?

Its already released https://github.com/team-carepay/traefik-jwt-plugin/releases/tag/v0.5.1

The issue is that available from traefik plugin hub only after some time. But if you use local plugins then you can already consume a release from this git tag.

lvijnck commented 1 year ago

@eshepelyuk is the release process automated, or is there a need to wait till a given date?

Its already released https://github.com/team-carepay/traefik-jwt-plugin/releases/tag/v0.5.1

The issue is that available from traefik plugin hub only after some time. But if you use local plugins then you can already consume a release from this git tag.

Thanks! Amazing PR turnaround time.