traefik / mesh

Traefik Mesh - Simpler Service Mesh
https://traefik.io/traefik-mesh
Apache License 2.0
2.03k stars 141 forks source link

Helm chart is assuming a `cluster.local` domain #278

Closed feisuzhu closed 5 years ago

feisuzhu commented 5 years ago

This is not true for our clusters

☸ this ☁  maesh [master] ag cluster.local
internal/k8s/client.go
365:        name regex ([a-zA-Z0-9-_]*)\.([a-zv0-9-_]*)\.maesh maesh-{1}-{2}.maesh.svc.cluster.local
368:    kubernetes cluster.local in-addr.arpa ip6.arpa {

integration/kubedns_test.go
31:     "exec", "-it", pod.Name, "-n", pod.Namespace, "-c", pod.Spec.Containers[0].Name, "--", "curl", "whoami.whoami.svc.cluster.local", "--max-time", "5",

integration/resources/kubedns/kubedns.yaml
122:            - --domain=cluster.local.
163:            - --server=/cluster.local/127.0.0.1#10053
195:            - --probe=kubedns,127.0.0.1:10053,kubernetes.default.svc.cluster.local,5,SRV
196:            - --probe=dnsmasq,127.0.0.1:53,kubernetes.default.svc.cluster.local,5,SRV

integration/resources/coredns/coredns.yaml
58:        kubernetes cluster.local in-addr.arpa ip6.arpa {
dtomcej commented 5 years ago

Hello @feisuzhu,

Is this something that you would like to be configurable?

Out of curiosity, what do you use for your clusters?

feisuzhu commented 5 years ago

Hello @feisuzhu,

Is this something that you would like to be configurable?

Out of curiosity, what do you use for your clusters?

Something like k8s.region1.in.example.com. We have several k8s clusters each have a different in-cluster domain and pod & service ip range, in case of possible interconnect requirements in the future.

dtomcej commented 5 years ago

Sounds like a valid reason.