The first step is not necessary and should be removed. The original idea was to check in the prepare command if the right CRDs are in place and that we can fetch resources before starting the controller. If it doesn't, the prepare command would fail. This make no difference compared to the controller failing.
I suggest we remove this check, this would allow a faster start time of the controller, and would allow us to remove the --acl flag from this command.
However, it could still be interesting to check if the right CRDs for SMI are installed, with the right version. But we shouldn't have to start informers for this.
Feature Request
The prepare command does two things:
Proposal
The first step is not necessary and should be removed. The original idea was to check in the prepare command if the right CRDs are in place and that we can fetch resources before starting the controller. If it doesn't, the prepare command would fail. This make no difference compared to the controller failing.
I suggest we remove this check, this would allow a faster start time of the controller, and would allow us to remove the
--aclflag from this command. However, it could still be interesting to check if the right CRDs for SMI are installed, with the right version. But we shouldn't have to start informers for this.Workarounds
It can be kept like that, it's just not optimal.