search

traefik / mesh

Traefik Mesh - Simpler Service Mesh
https://traefik.io/traefik-mesh
Apache License 2.0
2.02k stars 142 forks source link

fix code annotation and update deps #832

Closed nisainan closed 1 year ago

nisainan commented 1 year ago

What does this PR do?

This PR:

fix code annotation and update deps, replace value receiver with pointer receiver of struct Provider

How to test it

No test required

Additional Notes

Struct Provider has methods on both value and pointer receivers. Such usage is not recommended by the Go Documentation

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

ldez commented 1 year ago

Hello,

A PR with several subjects is not a good practice, you will have to split your PR to create one PR by subject.

You will also have to explain your changes (ex: why did you update each dependency)