Open FlowingSPDG opened 2 months ago
@ldez Hey, thanks for the review!
I applied your suggestion :) thank you!
All the following section:
should be replaced by:
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
architecture: ${{ matrix.arch }}
@ldez Hi, sorry for late response since I was busy!
I updated the actions but got Bad CPU type in executable
error on some job.
I'll dig into it and apply change if needed :)
Sorry you must remove:
architecture: ${{ matrix.arch }}
and the element related to the matrix.
Github action supports only amd64.
@ldez thank you for code suggestion, applied!
Hi, I tried to make a plugin by myself and noticed Go itself and several tools version are old so I updated.
Updated tools
go mod tidy -go=1.23
)Updated tool settings
goerr133
toerr133
fmt.Errorf
toerrors.New
Other
Maybe we can use
package plugindemo
instead ofpackage plugindemo_test
fordemo_test.go
since golangci-lint detectsdepguard
because it imports not-test package?