traefik / traefik-helm-chart

Traefik Proxy Helm Chart
https://traefik.io
Apache License 2.0
1.07k stars 752 forks source link

Enable tls for websecure in arguments #248

Closed rony36 closed 3 years ago

rony36 commented 4 years ago

From traefik 2.2, the TLS section in a Ingress don't control the activation of the TLS.

To enable TLS:

I suggest enable tls on the entryp point. That will be eazier to migrate from other ingress controller to treafik.

For example:

additionalArguments:                                                                                                                                                                                               
  - "--entryPoints.websecure.http.tls=true"

Or an additional tls config in values.yaml:

  websecure:                                                                                                                                                                                                       
    port: 8443                                                                                                                                                                                                     
    # hostPort: 8443                                                                                                                                                                                               
    expose: true                                                                                                                                                                                                   
    exposedPort: 443                                                                                                                                                                                               
    # The port protocol (TCP/UDP)                                                                                                                                                                                  
    protocol: TCP                                                                                                                                                                                                  
    # nodePort: 32443
    tls: true 
SantoDE commented 4 years ago

Can we somehow enhance this with https://github.com/containous/traefik-helm-chart/issues/190? Feels like it could make sense, no?

dirtycajunrice commented 4 years ago

@SantoDE I plan to add certResolver soon but need to get the rest of these smaller ones in, then do a formatting mr, then do the label mr then the pod tpl mr. Its in this order because the bigger ones get harder to do every time only a small one is done.

so short answer is yes they will work together but are not the same mr i think

si458 commented 4 years ago

@DirtyCajunRice was the any update on your PR? in theory its fine as is its just missing the test commits as it also supports HA traefik with multiple pods which dont support the ACME and require likes of cert-manager 👍 also the version number needs updating too sadly

dirtycajunrice commented 4 years ago

@si458 Just been a crazy 2 weeks for game releases havent had a second to make the requested changes. Will take care of it soon then ping. Thanks!

dirtycajunrice commented 4 years ago

@si458 Fixed version and added tests.