traefik / traefik-helm-chart

Traefik Proxy Helm Chart
https://traefik.io
Apache License 2.0
1.08k stars 763 forks source link

openTelemetry settings for v3.0.0-rc1 #999

Closed Links2004 closed 7 months ago

Links2004 commented 9 months ago

Welcome!

What version of the Traefik's Helm Chart are you using?

26.0.0

What version of Traefik are you using?

v3.0.0-rc1

What did you do?

we are trying to use OpenTelemetry tracing / metrics, but it looks like that the chart does not support this yes and is still using the old args for OpenTelemetry.

e.g. --tracing.openTelemetry=true vs --tracing.otlp.grpc=true

What did you see instead?

Treafik will not start when using the OpenTelemetry vaules.

What is your environment & configuration?

 tracing:
      openTelemetry:
        address: localhost:4318
        grpc: true

Additional Information

- https://doc.traefik.io/traefik/v3.0/observability/tracing/opentelemetry/
- https://doc.traefik.io/traefik/v3.0/observability/metrics/opentelemetry/
mloiseleur commented 9 months ago

Hello @Links2004 ,

That's right. This chart supports stable version of Traefik. Considering the changes on tracing, I'm unsure if and how it can be implemented in this Chart to support both v2 and v3.

Links2004 commented 9 months ago

openTelemetry is only supported by v3 and the chart handles this here:

https://github.com/traefik/traefik-helm-chart/blob/1f042ea9a0d354ebc00707bfd4e4f534a2a41859/traefik/templates/_podtemplate.tpl#L307-L310

https://github.com/traefik/traefik-helm-chart/blob/1f042ea9a0d354ebc00707bfd4e4f534a2a41859/traefik/templates/_podtemplate.tpl#L366-L369

mloiseleur commented 9 months ago

Ah yes, that's right. Thanks @Links2004