interp: Add wasip1 to known OS list

traefik / yaegi

Yaegi is Another Elegant Go Interpreter

https://pkg.go.dev/github.com/traefik/yaegi

Apache License 2.0

6.82k stars 342 forks source link

interp: Add wasip1 to known OS list #1587

Closed dennwc closed 10 months ago

dennwc commented 10 months ago

Adds wasip1 to known OS list, introduced in golang/go#58141.

Without this change, yaegi extract may fail on Go 1.21 with the following message:

type-checking package "time" failed (<GOROOT>/src/time/zoneinfo_wasip1.go:8:5: platformZoneSources redeclared in this block)

dennwc commented 10 months ago

@mvertes this one is small enough, should be fast to review.

mvertes commented 10 months ago

This will be addressed through bringing the full support of Go1.21 which is in preparation, thanks.

dennwc commented 10 months ago

@mvertes I would advocate for merging it earlier, since it prevents yaegi extract from working with Go 1.21 installation at all, even if the project is configured for Go 1.20.