traex / ExpandableLayout

Implementation of ExpandableListview with custom header and custom content.
MIT License
1.64k stars 361 forks source link

Please remove ic_launchers #41

Open MahdiAstanei opened 8 years ago

MahdiAstanei commented 8 years ago

the icons in the lib is cause of error: "Gradle finished with non-zero exit value 1"

darklordqnct commented 8 years ago

Error:Execution failed for task ':app:processDebugManifest'.

Manifest merger failed : Attribute application@icon value=(@mipmap/ic_launcher) from AndroidManifest.xml:22:9-43 is also present at [com.github.traex.expandablelayout:library:1.2.2] AndroidManifest.xml:13:9-45 value=(@drawable/ic_launcher). Suggestion: add 'tools:replace="android:icon"' to element at AndroidManifest.xml:19:5-55:19 to override.

dasheck0 commented 8 years ago

+1

You can workaround this by adding replace="android:icon" to the manifest like the following

<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    package="....">

    <application
        android:allowBackup="true"
        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:supportsRtl="true"
        android:theme="@style/AppTheme"
        tools:replace="android:icon"
        >
        ....
    </application>

</manifest>

But as you said it should be there in the first place so please remove it @traex

teodorpenkov commented 8 years ago

+1

flyingpic commented 8 years ago

it solved my problem by dasheck0's method

dasheck0 commented 8 years ago

Glad that it helped someone. But as all of us already mentioned it should be removed so that you donÄt need this workaround.

yanrubi commented 7 years ago

+1