update leaflet.draw - Githubissues

trafficonese / leaflet.extras

Extra functionality for leaflet R package.

https://trafficonese.github.io/leaflet.extras/

GNU General Public License v3.0

214 stars 74 forks source link

update leaflet.draw #120

Closed timelyportfolio closed 6 years ago

timelyportfolio commented 6 years ago

Update leaflet.draw and leaflet.draw.drag to their Leaflet > 1.0 version. Simply updating the JS/CSS worked near seamlessly.

Known remaining tasks:

[x] integrate new circle marker functionality - L.Draw.Circle.Marker, L.Edit.Circle.Marker, issue - fixed in e396c69
[x] test with mapedit

cc @schloerke, @jcheng5, @tim-salabim

Also, please notice that I opened a v1x branch as a pull target.

bhaskarvk commented 6 years ago

@timelyportfolio Do you want me to merge these PRs, or are you comfortable emrging them on your own?

timelyportfolio commented 6 years ago

@bhaskarvk Thanks for checking in. I am comfortable merging if you are. I still need to test a little further. So far, all seems to be working fairly well.

bhaskarvk commented 6 years ago

@timelyportfolio Please go ahead. I am really tied up with work/personal stuff, but I'll keep checking in from time to time if you need anything.

schloerke commented 6 years ago

closing as is merged into master