search

trafficonese / leaflet.extras

Extra functionality for leaflet R package.
https://trafficonese.github.io/leaflet.extras/
GNU General Public License v3.0
213 stars 74 forks source link

use latest rstudio/leaflet v2.0.0 and update plugins #128

Closed schloerke closed 6 years ago

schloerke commented 6 years ago

Includes PRs #108, #120

docs folder will contain the new website instead of gh-pages

@timelyportfolio

bhaskarvk commented 6 years ago

Great feel free to merge w/ master as you and @timelyportfolio see fit.

bhaskarvk commented 6 years ago

@schloerke So, about the docs folder, if we keep docs in master it unnecessarily increases the size of the tarball downloaded as part of devtools::install. It doesn't matter for CRAN install but I would also like to keep the master as small as possible. My workflow was add gh-pages branch as a git worktree called 'docs' in the current checked out folder. This way docs stay in gh-pages branch but pkgdown continues to work This does add two additional steps of setting up a git worktree on local clone and making sure to push gh-pages along w/ master, but keeps docs out of master.

schloerke commented 6 years ago

Fair. I guess I should have created a gh-pages-dev branch or something similar. I was protecting against having documentation with code that isn't downloadable (and also minimize work for you).

If you'd like to move them to gh-pages, I am all for it.

bhaskarvk commented 6 years ago

For now leave it as is and let's move it in future if someone complains about the size.